Bug FIX: Load/Save Translation and Rotation Flags#80
Merged
VitorSouzaLNLS merged 3 commits intomasterfrom May 9, 2025
Merged
Conversation
VitorSouzaLNLS
changed the title
VitorSouzaLNLS
requested review from
Gabrielrezende-asc,
fernandohds564,
vellosok75 and
xresende
fernandohds564
approved these changes
Apr 30, 2025
Contributor
|
@xresende, @vellosok75 , @Gabrielrezende-asc , please, take a look at this one. |
xresende
approved these changes
May 5, 2025
vellosok75
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
@Gabrielrezende-asc identified a bug in the save/load functionality for
pyaccel.accelerator.Acceleratorobjects when using pickle.This issue was introduced in Trackcpp's PR #71 and caused
Elementobjects to be loaded without correctly setting the t_in, t_out, r_in, and r_out flags.Fix:
This PR resolves the issue by using the
reflag_*auxiliary functions insideread_flat_file_trackcppfor corretly loading Accelerator objects from pickles in Python.The
reflag_*functions are also used inread_flat_file_tracy.Extra:
Changes also include the use of the
has_*flags insidewrite_flat_file_trackcpp.